Make 3rd party unit tests log "PERKELE" instead of "FUCKOFF" #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using this sample file as input to known hosts parsing unit tests. I don't mind a bit of swearing but this Finnish word is a bit more indirect than "FUCKOFF"
|
I don't understand - nothing in OpenSSH logs this string |
|
@djmdjm in OpenSSH maybe not, but try this from the source tree root: I'd like to keep using the latest file from OpenSSH source tree as input for my tests, which does dump the failing data in unit tests for debugging reasons. |
|
Why should the Finns have all the fun ? If the issue is the swearing, then change it to "GoAway", it's both easy to understand and not swearing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this sample file as input to
known_hostsparsing unit tests. I don't mind a bit of swearing but this Finnish word is a bit less direct than "FUCKOFF".Reference: https://www.youtube.com/watch?v=g56Izmup9zw